Wikipedia talk:XFDcloser/Archive 6

Latest comment: 2 months ago by Novem Linguae in topic Bug with CFD closes
Archive 1Archive 4Archive 5Archive 6

AfD close rationale not printed bug

At Special:Diff/1163774587 by @Star Mississippi, I noticed that the closing rationale is not printed at the AfD page; despite it simultaneously being added to its edit summary, and the concerned article's talk page (Special:Diff/1163774589). CX Zoom[he/him] (let's talk • {CX}) 12:24, 6 July 2023 (UTC)

The edit summary seems a bit screwy too, what with the inclusion of a broken [www.foo.com/nowiki link], which usually means someone handwrote the edit summary and forgot how links work. signed, Rosguill talk 14:26, 6 July 2023 (UTC)
THanks for flagging @CX Zoom. @Rosguill I am 100% guilty of forgetting how links (and formatting!) work, but I closed it with the script. Do links not work within that? I don't typically include them but in this case where I wasn't the nom who had withdrawn, I thought it helpful. Let me know if you need me to troubleshoot anything else. Star Mississippi 23:04, 6 July 2023 (UTC)
I mean technically it should not have disappeared completely from the AfD page while it appeared just fine at the article's talk page, despite both the actions being handled by a single click of script. CX Zoom[he/him] (let's talk • {CX}) 23:20, 6 July 2023 (UTC)
I suspect that putting either a hyperlink or a wikilink into the close rationale is what broke this. Given that the withdrawal is clearly on the page I'm not quire sure why it would be necessary to link to the diff itself on the word withdrawn anyway... I guess it's not quite GIGO but it's "unexpected behaviour leads to things breaking". Primefac (talk) 10:16, 7 July 2023 (UTC)
Trying to find the note where someone asked me to make nom withdrawn closes more clear, but can't now. Happy to do those with a post close edit. Thanks both! Star Mississippi 14:10, 7 July 2023 (UTC)
My suggestion would be to add the explanatory note in the Rationale section (which allows for a boatload of exposition if necessary). Ideally the word in the custom close box should be 1-2 words only. Primefac (talk) 14:15, 7 July 2023 (UTC)
Oh that makes total sense and I'll happily take the "duh trout" for not doing that in the first place. I'm not sure why I linked it in the outcome to begin with. Star Mississippi 14:59, 7 July 2023 (UTC)

"Not yet 7 days" warning should be right away

"Not yet 7 days" warning is currently after you go through a couple screens and try to finalize the closing of the XFD. (In my case for RFD.) I suggest moving this check and notification to the very beginning, when you first open XFDCloser, so as to reduce wasted time. –Novem Linguae (talk) 15:31, 14 July 2023 (UTC)

I am not disagreeing with your proposal (it's a good idea), but the close buttons are colour-coded to indicate whether enough time has passed... Primefac (talk) 11:46, 18 July 2023 (UTC)
Ah, I see now. Pastel yellow for too early, pastel green for ready to close. Neat. –Novem Linguae (talk) 13:25, 18 July 2023 (UTC)

Preferences should let you set "Add edited pages to your watchlist" to limited duration

There is a setting in the preferences screen called "Add edited pages to your watchlist". The choices are "always", "never", and something else. I propose adding some limited durations to this, such as "1 week", "1 month", etc. I would personally want to watchlist these pages for about a week or a month, and after that I'd like them to drop off my watchlist to avoid clutter. –Novem Linguae (talk) 16:19, 14 July 2023 (UTC)

Okay, this might be me being dumb, but... what preferences screen? Primefac (talk) 11:49, 18 July 2023 (UTC)
I can pull it up by clicking "[Close]", then clicking "Preferences" in the bottom left. Hope that helps. –Novem Linguae (talk) 13:22, 18 July 2023 (UTC)
Oh, right. Duh. Thanks. For some reason I thought it was stored somewhere else. The third option, by the way, is "default" (which is set in the generic Special:Preferences). Now that I think about it, that option should have some granularity as well, given that it's either "always" or "never", but that's a phab issue not an XFDC issue. Primefac (talk) 13:56, 18 July 2023 (UTC)
Agree largely that this would be a nice thing to have; I've definitely taken to short-watch-listing things like this just to make sure there isn't any weird fallout. Primefac (talk) 13:56, 18 July 2023 (UTC)

CfD relisting date bug?

Some recent CfD relistings appear to be linking to the wrong page (example). Could you check if this is an error with XFDcloser or something else? —Paul_012 (talk) 07:12, 21 July 2023 (UTC)

@Paul 012, I'd says that's a bug with XFDCloser. The relisting link is correct, but the discussion is moved to the wrong date (the 18th) and the summary also links to the 18th. I suspect the relsit link is only correct (the 19th) because it substitutes a template, instead of using what it thinks is the current day. Qwerfjkltalk 08:21, 21 July 2023 (UTC)

The above was copied from User talk:Qwerfjkl#Relisted CfDs linking to wrong date.

This appears to have since been resolved, but someone might want to look into the causes. --Paul_012 (talk) 17:50, 23 July 2023 (UTC)

Disappeared?

This seems to have disappeared from my screen completely. Any ideas why? Skin compatibility, withdrawn, affected by other scripts, perhaps? Unfortunately, DannyS127 hasn't been around for a bit. Hope he's well. SN54129 17:08, 14 August 2023 (UTC)

@Serial Number 54129, what skin are you using and what page(s) does the issue occur? Qwerfjkltalk 20:34, 14 August 2023 (UTC)
Thanks Qwerfjkl for looking in... wierdly, it seems to have appeared again since last night. I spent a lot of time messing around un/reinstalling stuff, and refreshing, and using different versions, and logging in and out, so among all those things I guess I must've clear something! Don't ask me how though  :) SN54129 11:38, 15 August 2023 (UTC)

Two cats in the same action loses one, and processes the other

https://en.wikipedia.org/wiki/Category_talk:Physical_systems#Did_a_maintenance_process_just_stop,_or_has_a_process_hung_up?

It appears that the xfd for Cat Conceptual system got logged, but Cat Physical system got lost. I did it manually. -- Ancheta Wis   (talk | contribs) 20:10, 15 August 2023 (UTC)

It is not clear to me whether Wikipedia:Categories for discussion/All old discussions gets an entry. I believe it would be moot because the Cats should have been processed. --Ancheta Wis   (talk | contribs) 23:14, 15 August 2023 (UTC)

TfM tag messing up XFDc

The TfM tag at {{pagelinks}} seems to be messing with XFDc, making it think the page nominated was Template. See Special:Diff/1174719924. CLYDE TALK TO ME/STUFF DONE 07:18, 10 September 2023 (UTC)

Should be sorted now. Primefac (talk) 11:14, 10 September 2023 (UTC)

Misinterpreting section headers as discussions on TfD

Failure to de-tag a CfD

When closing Wikipedia:Categories_for_discussion/Log/2023_September_25#Category:Jewish_athletes_(track_and_field) as no consensus, XfDcloser failed to remove the CfD tags from the nominated categories. –LaundryPizza03 (d) 19:12, 6 October 2023 (UTC)

Bug report: Non-category talk receives old CfD notice

When closing a CfD, the disambiguation page Reply sometimes appears as one of the pages, and Talk:Reply receives a spurious old CfD notice. This happened at Wikipedia:Categories_for_discussion/Log/2023_April_30#Category:French_Polynesian_musicians and Wikipedia:Categories_for_discussion/Log/2023_October_7#Category:Latin-language_writers. –LaundryPizza03 (d) 16:08, 15 October 2023 (UTC)

Steps to reproduce:

  • Android, Firefox
  • Tick "view in desktop mode"
  • Log in
  • Install XFDcloser
  • Visit an MFD page
  • Click "close"
  • Click on a textbox to start typing

What happens?

  • Modal becomes very short, is unreadable and unusable until the keyboard is closed

What should happen instead?

  • Modal should be usable. CSS min-height could solve the issue.

Novem Linguae (talk) 16:03, 30 October 2023 (UTC)

Draftification

I'm wondering if there's an easier way to implement a "draftify" closure at AfD than what I'm currently doing. Ideally, this would involve a) moving the page and associated talk page to draftspace, b) removing AfD templates and logging the old AfD on the talk, and c) the option of unlinking backlinks, for topics deemed temporarily not notable. If it's not currently a feature, it would be an extremely useful one.

Also, given that this page is likely to be a long list of requests and/or complaints, I wanted to express my appreciation for this tool, and the enormous time savings it has created. Vanamonde (Talk) 20:37, 11 November 2021 (UTC)

To add to this, I'd also suggest it removes any project quality ratings (can leave the importance ones) as part of this process. Thanks. -Kj cheetham (talk) 10:30, 13 November 2023 (UTC)

Multiple retargets for batch RfD not working

Steps to replicate the issue: Try closing a batch nomination at RfD using XFDcloser and select the option for "multiple results". For one of the pages, select "retarget" and try to type the name of the new target page.

What happens?: When prompted for a new target, the field freezes and does not allow typing words. Typing certain letters causes the result to be altered (e.g., 'k' for keep), while others have no effect. Attempting to abort the "multiple results" closure keeps all fields frozen, i.e., a blanket "retarget" closure is not possible, and it is impossible to add an additional rationale following one of the default results. It is necessary to refresh the browser page to unfreeze XFDcloser.

What should have happened instead?: It should be possible to specify independent pages to which each nominated page will be retargeted, and proceed with the close. Any issues at this step also should not affect alternate closure options when backtracking.

Complex/Rational 00:56, 24 January 2024 (UTC)

Request: turn off minifier

MediaWiki:Gadget-XFDcloser-core.js is minified, making debugging harder. I suggest turning off minifying. mw:ResourceLoader has its own minifier, so I don't see much of a performance benefit here, and the tradeoff is harder debugging and a barrier to entry for other devs that want to read this code. –Novem Linguae (talk) 18:26, 24 January 2024 (UTC)

I mean, the original source code is a bunch of different js files that have to be packed together into this one file and transpiled to work here. I don't think turning off minifying would help much when the code isn't meant to be read in this compiled form. Galobtter (talk) 02:45, 25 January 2024 (UTC)
Is there even a way to configure a module bundler like webpack or rollup to pack multiple JS files into a single unminified file? Back when I was working on a similar project in 2020-21, the only way was through debug modes in which webpack would still inject lots of boilerplate code which aren't optimal for production, and can make a large gadget like this approach the 2 MB size limit.
I doubt if things would have changed since then. Although the JS ecosystem is fast-moving, there is little demand for tools that generate unminified production builds, as the wider web doesn't use ResourceLoaders. – SD0001 (talk) 13:27, 25 January 2024 (UTC)
In webpack, that's optimization: { minimize: false }. Example at User:Suffusion of Yellow/fdb-worker.js; that's fairly readable, though a few clashing variables might have been renamed. Suffusion of Yellow (talk) 23:14, 27 January 2024 (UTC)

Discussion at Wikipedia:Village Pump (proposals) § Bump XfD heading sizes

Empty see also section left

In this edit, the only link in a "See also" section was removed but the heading remained. Preferably, it would remove the heading in that case. ~Bobogoobo (talk) 05:37, 19 May 2024 (UTC)

Are XFDcloser links supposed to show for RFD/TFD/etc entries that are hatted? Currently the links are showing in some cases. I am wondering if this is a bug, or useful behavior. –Novem Linguae (talk) 02:36, 2 June 2024 (UTC)

I figured it out. They are not supposed to show for hatted sections, relisted sections on the old page, etc. The XFDcloser links are supposed to be hidden if the XFD is already actioned. –Novem Linguae (talk) 04:27, 2 June 2024 (UTC)

Problem with relisting

I relisted around 7 or 8 discussions and they were removed from the 8/10/23 AFD log page but not put on to the 8/17/23 page. So, I cut and pasted them manually. But relisting happens a lot so I hope whatever problem is happening can get fixed. Thanks. Liz Read! Talk! 03:22, 17 August 2023 (UTC)

So, XFDcloser did relist discussions but to the wrong date, to August 16th even though it became August 17th UTC hours ago. Anyone else seeing this problem? Liz Read! Talk! 04:48, 17 August 2023 (UTC)
@Liz, #CfD relisting date bug?. Yes, me. Qwerfjkltalk 09:37, 17 August 2023 (UTC)
Hello, Qwerfjkl,
Thanks for pointing this out. I wonder how often the XFDcloser developers monitor this talk page. Liz Read! Talk! 06:06, 27 August 2023 (UTC)
I have been posting here since early last year, and I don't see any one monitoring this talk page. Jay 💬 06:31, 27 August 2023 (UTC)
@Jay, @Liz, see #Relisting failure at CFD above; the sole maintainer has been inactive for a year and a half. Qwerfjkltalk 06:37, 27 August 2023 (UTC)
I've got this page watchlisted and may jump in and write patches at some point. Just need some free time. –Novem Linguae (talk) 20:31, 27 August 2023 (UTC)
This relisting problem is still an issue. I relisted several discussions last night where the AFD discussions weren't removed from the daily log page. But the bigger problem is when XFDcloser removes the discussion from the current daily log but doesn't repost it to the future daily log so the discussion completely disappears from our AFD pages. We used to have a few editors who looked for AFD discussions that fell through the cracks like this and were never closed and they would repost them, sometimes months later. I'd say we have XFDcloser relisting problems about 1-5% of the time so it's not often but it's regular enough that I wish a developer would look into it. Liz Read! Talk! 02:36, 11 January 2024 (UTC)
The next time this happens, if y'all can provide some diffs, that would help with debugging. I'll need to copy wikicode of several pages over to testwiki to try to recreate this, and diffs would provide this wikicode. –Novem Linguae (talk) 06:55, 7 June 2024 (UTC)
Above, someone mentioned that it was relisting to the wrong log page. Below, someone mentioned that it was not relisting to any log page, or did not remove the relist from the old log page. Hmm.
Someone mentions this happens on 1-5% of relists. 1-5% of the time could be a wikicode issue (easy to fix), the log page not created yet (easy to fix), a race condition (hard to fix), or connection issues such as jQuery error http (hard to fix). –Novem Linguae (talk) 07:00, 7 June 2024 (UTC)

Hi all

About a week ago, XFDcloser has vanished from when I view AfD's. I have checked across three different computers, all of which use Google Chrome (latest version).

Have tried deactivating and reactivating through preferences, also to no avail.

I am technologically deficient in many respects so I'm sure I'm missing something obvious - has anyone else encountered this issue, or alternatively does anyone know a fix I should try?

Cheers
Daniel (talk) 21:48, 27 May 2024 (UTC)

@Daniel. Any WP:CONSOLEERRORs on pages where you expect XFDCloser to display? –Novem Linguae (talk) 01:15, 28 May 2024 (UTC)
Hi User:Novem Linguae, three it seems (tested on page Wikipedia:Articles for deletion/EcoCute (Japan)):
Do I have any idea what any of these mean? You bet I don't! Any help obviously greatly appreciated. Daniel (talk) 01:55, 28 May 2024 (UTC)
Those are just notices and arent the smoking gun i was hoping for. Thank you for checking though. –Novem Linguae (talk) 03:03, 28 May 2024 (UTC)
OK, so...I changed from Monobook to Vector (2022) and the closing buttons have reappeared (with no other changes on my part). It's a shame, cos I love Monobook (call me old-fashioned), but it seems like something with the Monobook isn't agreeing with XFDCloser. They also work in Vector Legacy (2010) and that looks similar to Monobook, so that's a suitable workaround from my perspective. Daniel (talk) 03:17, 28 May 2024 (UTC)
Daniel, there were recent changes to the header HTML for certain skins, which is probably what caused this. These changes will also be rolled out for both vectors at some point in the future. Qwerfjkltalk 05:53, 28 May 2024 (UTC)
Hi Qwerfjkl, thanks for the update. Confirming both Vectors are working as of right now...with any luck Monobook will work nicely with XFDCloser some time in the future, although it's not a massive issue to use Vector (2010). Daniel (talk) 06:42, 28 May 2024 (UTC)
I'm able to reproduce on Monobook. This should be pretty easy to patch. The hard part will be figuring out how to test and deploy it. Looks like this tool hasn't had a patch in two years so it's unlikely the maintainer is around. I might look into this tomorrow. –Novem Linguae (talk) 10:02, 28 May 2024 (UTC)
OK, I figured it out and wrote a patch. I'll give @Evad37 a couple days to see the GitHub emails and see if they want to comment. If Evad is MIA, I have enough access to deploy this (intadmin, wikimedia-gadgets member), but would rather check with them first :) –Novem Linguae (talk) 15:17, 29 May 2024 (UTC)
I probably should have mentioned this earlier, but it's due to mw:Heading HTML changes; see also the phab ticket linked there. Qwerfjkltalk 06:38, 30 May 2024 (UTC)
Came here to ask about this, and see there's already a fix in the pipeline. Much appreciated, Novem Linguae. Seraphimblade Talk to me 19:06, 1 June 2024 (UTC)
I just did a deployment. Should be Fixed.
Please ping me if the deployment breaks anything. It's my first time deploying for this repo. The minified file has an unexplained -50,000 bytes. However my quick checks didn't find anything broken. –Novem Linguae (talk) 11:57, 2 June 2024 (UTC)

RFC: Priorities for XFDcloser development in 2022

What are the highest priority software bugs and feature requests for XFDcloser? - Evad37 [talk] 14:30, 12 January 2022 (UTC)

The backlog of bugs and feature requests as noted in the other sections of this page has built up quite a lot, especially over the past year or so while I haven't been so active on Wikipedia. Finding out what the community's priorities are would help me, as the primary author/maintainer of XFDcloser, to decide the order in which I work on issues. Note that responses here will just be one factor, with the other main factor being the scope/complexity of coding changes required. - Evad37 [talk] 14:30, 12 January 2022 (UTC)

Notifying the nominator

Would it be possible to have the script automatically post a message on the nominator's talk page once a discussion is closed? There would need to be a way for nominators to disable that if it annoys them though; not sure how it could be done. Cocobb8 (💬 talk • ✏️ contribs) 20:08, 10 June 2024 (UTC)

No comment on the feature, but more than a feature discussion, I think this is about responsibility. Of all participants, I believe the nominator ought to be the most responsible in tracking the discussion and seeing where it is going. For 7-day discussions, if I was a nom, I would check daily or once in two days. As part of making the nomination, the nom would also have the relevant pages in the watchlist. Jay 💬 07:46, 11 June 2024 (UTC)
Not sure this is necessary; just to use TFD as an example, there are a few editors who nominate dozens of pages every week for relatively mundane reasons, and they likely do not need or want to know the outcome of those discussions (never mind the fact that they're probably watching the template itself and will get a notification when the discussion is closed). They don't also need dozens of talk page notices each week telling them the outcome. Primefac (talk) 01:02, 15 June 2024 (UTC)

Evad37 feature ideas

Moved from top of page to its own talk page section. I think Evad37 wrote these. –Novem Linguae (talk) 16:36, 15 June 2024 (UTC)

Most urgent bugs

Howdy folks. I might be interested in doing some work on this gadget. And there's like 100 sections on this page. Can you please give me a recap of what you think the most serious bugs are? So I can start to prioritize. Feel free to link to the appropriate sections above too. Thank you. P.S. Let's focus on bugs rather than feature requests for now. –Novem Linguae (talk) 02:32, 2 June 2024 (UTC)

Novem Linguae, at CfD, the only major bug I've experienced is that XfDCloser can't handle nominations with >50 pages; it'll have something like "http error". This is probably due to the limit of 50 pages per API request for non-admin or bot accounts (the higher limits are 500), and XfDCloser doesn't batch requests properly. Sometimes this error causes XfDCloser to fail on the rest of the page, though this is pretty rare. Qwerfjkltalk 11:32, 2 June 2024 (UTC)
Biggest bugs seem to be around RFD and CFD. This thread from 2022 also has some of the "best of" issues that people are experiencing. I also noticed (going through all of the threads on this page) that many of these are likely one-time issues (and a few of them actually were resolved and just not archived). I'll try to do a second pass... soonish... and tag the ones that I think were sorted out Primefac (talk) 10:45, 7 June 2024 (UTC)
Yes, Fayenatic london's comments there are pretty much all still applicable to CfD. Qwerfjkltalk 14:32, 7 June 2024 (UTC)
@Fayenatic london's comments in #RFC: Priorities for XFDcloser development in 2022 were great. I turned each comment into a ticket just now. I also ticketized the other comments in that section. Ticketizing the big issues is a good first step to getting a volunteer developer to work on this stuff. –Novem Linguae (talk) 10:23, 11 June 2024 (UTC)
Novem Linguae, I've submitted a pull request that (should) fix this, would appreciate if you could take a look at it. Qwerfjkltalk 20:56, 25 June 2024 (UTC)
Novem Linguae, I probably should have mentioned this before, but:
The main bug I have is XFDCloser not loading. It fails haphazardly, so I assume the issue is a race condition with other scripts. For reference, heres what my HTML looks like with the other scripts loaded (not XFDCloser):
<h4 data-mw-thread-id="h-Category:Legendary_creatures-June_12-20240602121000" style="overflow: visible;" title="Latest: 9 days ago | 10 comments | 8 contributors" class="xfd-closed">
  <span class="mw-headline" id="Category:Legendary_creatures">
    <span data-mw-comment-start="" id="h-Category:Legendary_creatures-June_12-20240602121000"></span>Category:Legendary creatures <span data-mw-comment-end="h-Category:Legendary_creatures-June_12-20240602121000"></span>
  </span>
  <a class="copy-section-link-pilcrow" display="inline"></a>
  <span class="mw-editsection">
    <span class="mw-editsection-bracket">[</span>
    <a href="/w/index.php?title=Wikipedia:Categories_for_discussion/Log/2024_June_12&amp;action=edit&amp;section=6" title="Edit section: Category:Legendary creatures" class="nonimage sectionEditLink">
      <span>edit</span>
    </a> | <a class="copysectlink mw-selflink-fragment nonimage" href="/wiki/Wikipedia:Categories_for_discussion/Log/2024_June_12#Category:Legendary_creatures" role="button" title="#Category:Legendary creatures">copy</a> | <a>List discussion</a> | <span class="dropdown-container" style="position:relative; display:inline-block; ">
      <a class="dropdown-trigger" style="color: #0645AD; text-decoration: none; cursor: pointer">One click close</a>
      <span class="dropdown-menu" style="display: none; position: absolute; background-color: #fff; border: 1px solid #ddd; box-shadow: 0 2px 5px rgba(0, 0, 0, 0.1); padding: 5px; min-width: 6em; z-index: 1; left: 0px; top: 0.8em;">
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">delete</a>
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">rename</a>
        <a style="display: block; color: #0645AD; text-decoration: none; padding: 10px; margin-top: 5px; font-size: 150%" class="dropdown-item">merge</a>
      </span>
    </span>
    <span class="mw-editsection-bracket">]</span>
    <span id="FTTLink-heading-82" class="FTTLinks FTTHeadingLinks">
      <a title="Permanent link" href="#Category%3ALegendary_creatures" id="genLink-82" class="FTTGenLink" tabindex="0">
        <span class="FTTReplyLink FTTSVG FTTSVGLinkIcon">
          <span class="FTTScreenReaderLabel" data-content="Permanent link"></span>
        </span>
      </a>
      <a tabindex="0" class="FTTCmtA" onclick="event.preventDefault();event.stopPropagation();FTT.openReplyForm(FTT.PRM[82])">
        <span title="Add new comment or subsection" class="FTTReplyLink FTTSVGNewSectionIcon FTTSVG">
          <span class="FTTScreenReaderLabel" data-content="Add new comment or subsection"></span>
        </span>
      </a>
      <a tabindex="0" class="FTTSecEdit">
        <span title="Edit section" class="FTTReplyLink FTTSVGEditIcon FTTSVG">
          <span class="FTTScreenReaderLabel" data-content="Edit section"></span>
        </span>
      </a>
      <span>
        <a tabindex="0" title="Subscribe" class="FTTSubscribe FTTSVG FTTReplyLink FTTSVGBellIcon" onclick="FTT.stalkSubscribe(FTT.PRM[82],'bellicon',null,event);">
          <span class="FTTScreenReaderLabel" data-content="Subscribe"></span>
        </a>
      </span>
    </span>
  </span>
</h4>
It would be nice if XFDCloser was more robust at handling this kind of stuff. (And yes, I realise there's an open phab ticket for an API to add links to section headers). Qwerfjkltalk 17:57, 21 June 2024 (UTC)
Sounds like the page is Wikipedia:Categories for discussion/Log/2024 June 21#Category:Legendary creatures. What skin are you using? What percent of the time does it fail? Does it fail often enough that you could disable half your user scripts, then another half, etc. to narrow it down to one user script that it's conflicting with? When it fails, are there any WP:CONSOLEERRORs? –Novem Linguae (talk) 02:39, 22 June 2024 (UTC)
Novem Linguae, Vector 2022; about half perhaps, hard to pin down; the scripts are probably WP:FACTOTUM, User:Enterprisey/copy-section-link (or something similar; I seem to have that disabled), User:Nardog/CopySectLink, and User:Qwerfjkl/scripts/CFDlister. There are no console errors. I will see if I can get a screen recording. Qwerfjkltalk 15:22, 22 June 2024 (UTC)
I was able to reproduce using your common.js settings. I agree that it's probably a race condition. If another user script changes the HTML in that area, it could mess up XFDcloser's attempt to add its links. Might try disabling WikiNotes as a test and see if that fixes it, because that user script is putting links in the same area as XFDcloser. If that doesn't work, because I'm able to reproduce it, we know that it's something in your common.js, so you could use a bisect technique to figure out what script is conflicting. Bisecting involves commenting out half of your common.js, then seeing if that fixes it. If it does, then comment out half of that. If it doesn't, then re-enable that half and comment out the other half. And so on and so forth. You'd have to refresh a bunch of times to be sure since this is only happening like 50% of the time. –Novem Linguae (talk) 14:18, 23 June 2024 (UTC)
As typical, the issue has disappeared for now. I'll report back when it reappears. Qwerfjkltalk 15:12, 23 June 2024 (UTC)
Novem Linguae, here's a screen recording (if it helps):
 Qwerfjkltalk 15:03, 28 June 2024 (UTC)
Thanks. I think disabling WikiNotes and seeing if that fixes it might be a good next step. –Novem Linguae (talk) 15:54, 28 June 2024 (UTC)
Novem Linguae, I'm not sure which script you're referring to by "WikiNotes". Qwerfjkltalk 17:28, 28 June 2024 (UTC)
Hmm. Not sure how I got the word "WikiNotes" into my head. I think I was referring to the pencil icon and similar icons in the CFD heading sections in V22, which I think are placed there by Factorum. So I guess my recommendation is to turn off Factorum for a bit and see if that fixes things. –Novem Linguae (talk) 18:10, 28 June 2024 (UTC)
Looks like that was the problem; I guess a 3 second delay wasn't long enough. Qwerfjkltalk 18:40, 28 June 2024 (UTC)
Excellent.
Resolved
Novem Linguae (talk) 18:53, 28 June 2024 (UTC)

XFDCloser not showing up in Vector 2010

Resolved

For some reason, the regular XFDcloser options are not showing up on AFD discussions. I've uninstalled all of the programs and unselected the gadget. Then I selected the gadget again in the Preferences again but still, no options appear that would allow me to close a discussion. What's up here? Liz Read! Talk! 23:21, 6 June 2024 (UTC)

This is likely a WP:THURSDAY issue. They done broke something big in this one because it's not the only one I've seen today. Primefac (talk) 00:34, 7 June 2024 (UTC)
Also noting that this has been (properly) reported at WP:VPT. Primefac (talk) 00:35, 7 June 2024 (UTC)
Yes, I went to VPT when I realized that I was unlikely to get a response here. And yet, I did! Liz Read! Talk! 03:53, 7 June 2024 (UTC)
I'm able to reproduce. Will load up the dev version and step debug it after dinner. P.S. It's broken in Vector and not Timeless, so maybe they implemented mw:Heading HTML changes on modern skins (vector, vector-2022, minerva) today. WP:THURSDAY. –Novem Linguae (talk) 04:25, 7 June 2024 (UTC)
Should be Fixed. –Novem Linguae (talk) 06:51, 7 June 2024 (UTC)
Looks like, thanks! Primefac (talk) 10:21, 7 June 2024 (UTC)
I am on Vector Legacy 2010 (always have been) and the problem persists. Jay 💬 13:00, 7 June 2024 (UTC)
Link to example page? Ill try loading your common.js and see if something is conflicting. –Novem Linguae (talk) 13:30, 7 June 2024 (UTC)
I was referring to RfD. Sorry for not mentioning. I have switched to Vector 2022 temporarily until Vector 2010 is fixed. Jay 💬 05:34, 8 June 2024 (UTC)
@Jay. I am unable to reproduce at Wikipedia:Redirects for discussion/Log/2024 June 1#2023-24 Major Clubs Limited Over Tournament. I see green close, quickClose, and relist links. Can you please confirm you don't see them? Can you also please post a screenshot? Do you have any WP:CONSOLEERRORs? –Novem Linguae (talk) 10:35, 11 June 2024 (UTC)

I don't see the green close, quickClose and relist links. When I change my skin from Vector 2010 to 2022, and refresh the RfD page, I see them. When I switch the preference back to 2010, the links are no longer seen. How do I post a screenshot? I was on Edge, but tried on Chrome as well. I see console errors like

2024_June_1:547  This page is using the deprecated ResourceLoader module "codex-search-styles".
[1.43] Use a CodexModule with codexComponents to set your specific components used: https://www.mediawiki.org/wiki/Codex#Using_a_limited_subset_of_components
(anonymous) @ 2024_June_1:547
startup.js:1307  This page is using the deprecated ResourceLoader module "jquery.ui".
Please use Codex instead.
execute @ startup.js:1307
startup.js:1307  This page is using the deprecated ResourceLoader module "mediawiki.ui".
[1.41] Please use Codex. See migration guidelines: https://www.mediawiki.org/wiki/Codex/Migrating_from_MediaWiki_UI
execute @ startup.js:1307
index.php?title=User:PrimeHunter/Source_links.js&action=raw&ctype=text/javascript:36
10Third-party cookie will be blocked. Learn more in the Issues tab.

 Preceding unsigned comment added by Jay (talkcontribs)

Thanks for that. Deprecation notices aren't anything to worry about. We're looking for things like "error" and "uncaught". Here's a graphic with more details about what to look for in the console.
To take a screenshot, you press your "Prt Scn" key, open a graphics program such as MS Paint, paste it in, save it, then upload it somewhere. Third party sites like imgur.com can be good for this if you're OK with not using FOSS. If you want to upload it to Commons for FOSS reasons, then you'd want to use c:Special:UploadWizard, although there are many more restrictions due to copyright. For example, you're supposed to crop out your operating system unless it's Linux, and you're only supposed to screenshot open source browsers such as Firefox, rather than proprietary software such as Chrome or Edge.
Two useful screenshots would be 1) the RFD page (so I can verify your skin) and 2) the console (so I can look at the error messages). –Novem Linguae (talk) 11:53, 11 June 2024 (UTC)
Actually, don't worry about the screenshots. I was able to reproduce this just now. Let me dig into it and I'll get back to ya. –Novem Linguae (talk) 11:58, 11 June 2024 (UTC)
[edit conflict] No, there are no errors. I know to take screenshots, uploading them was the question. Definitely do not want to upload to Commons where it will be permanent. Same for imgur I guess. Is there a site where images are kept for a day or so and purged? That will be perfect for screenshots. Jay 💬 12:03, 11 June 2024 (UTC)
Sent you the requested screenshots. Jay 💬 18:40, 11 June 2024 (UTC)
@Jay, Hey man im josh, and The Herald:. I deployed a fix related to the beta version of XFDcloser. Can you try again and let me know if things are fixed? –Novem Linguae (talk) 00:50, 13 June 2024 (UTC)
@Novem Linguae: It's back for me, at least with desktop mode from Chrome browser on my phone. Hey man im josh (talk) 00:57, 13 June 2024 (UTC)
Yes, awesome, you are the GOAT! Jay 💬 05:30, 13 June 2024 (UTC)
Amazing. Works perfect. I just love Monobook and didn't wanna switch. Thank you and happy editing :) The Herald (Benison) (talk) 13:02, 13 June 2024 (UTC)

July

I am using Vector 2022 and the XFDcloser options are not appearing for me. plicit 23:40, 18 July 2024 (UTC)

mw:Heading HTML changes#Wikimedia wikis. I need to release another patch :( –Novem Linguae (talk) 23:43, 18 July 2024 (UTC)
Fixed. Hotfix released. Should take effect within 15 minutes as caches clear. –Novem Linguae (talk) 00:21, 19 July 2024 (UTC)
That was quick. Thanks! plicit 02:34, 19 July 2024 (UTC)

Relist date calculation bug

Hello, whomever watches this talk page,

I'm using XFDCloser and, for some reason, when I relist a discussion from the AFD daily log for August 6th, it gets posted on Wikipedia:Articles for deletion/Log/2024 August 12 instead of Wikipedia:Articles for deletion/Log/2024 August 13 even though it is almost 04:00 UTC, well into August 13th. This isn't the first time this has happened but it usually gets resolved after an hour or two into the new day. Any assistance or suggestions would be welcome. Liz Read! Talk! 03:54, 13 August 2024 (UTC)

This is likely a user-side issue rather than a tool issue; I've had that before when not in UTC itself. Primefac (talk) 11:51, 13 August 2024 (UTC)
Can you link an example please? Also, what is your time zone? If you're comfortable giving it out. –Novem Linguae (talk) 12:48, 13 August 2024 (UTC)
I can give one myself, Special:Diff/1235376090 and Special:Diff/1235376112. I was traveling at the time; it's happened to me before and seems to occur when my local time does not match my computer time. Primefac (talk) 13:02, 13 August 2024 (UTC)

Request to change script to use certain template

I was wondering if you could make a slight modification to this script so that it uses Template:XfD relist over the redirect Template:Relist. I want to make the redirect a dab page, so any help with that script would be greatly appreciated. Interstellarity (talk) 20:01, 12 August 2024 (UTC)

@Interstellarity: For what it's worth, I'm all about having this gadget use the target instead of the redirect, but converting Template:Relist into a disambiguation page is controversial: Such a major change to the way things have been done for over a decade probably needs discussion at WP:RFD. Steel1943 (talk) 16:24, 22 August 2024 (UTC)
@Steel1943: Thanks. I might consider listing the redirect at RFD at some point, but I don't see a need right now to do it. Interstellarity (talk) 00:59, 23 August 2024 (UTC)

TFD/FFD relist wikicode

Hi, I don't use XFDcloser so sorry if this makes no sense. Recently I was confused by a line looking like this:

Relisted on 01 Jan 1901.

but with all the other links around I never thought that the way to go to the relisting was to click on the date. A wikilink text should say what the link will go to, but this one does not. So I propose that it instead should look like one of these:

Relisted on 01 Jan 1901.
Relisted on 01 Jan 1901.

Note that these link to the same place but now it says that the relisting is there whereas it didn't before. Perhaps this comment applies to other things too; I don't know. Thanks for considering. Zerotalk 13:00, 25 August 2024 (UTC)

Got a diff? There's a lot of different xfd log pages and I want to make sure we're talking about the same one. –Novem Linguae (talk) 13:53, 25 August 2024 (UTC)
I believe it is content such as Wikipedia:Templates for discussion/Log/2024 July 30 § Template:Move topicon. Primefac (talk) 14:24, 25 August 2024 (UTC)
Yes, that's it. In my case it was an image, but same idea. Zerotalk 14:50, 25 August 2024 (UTC)
OK, I'm glad I asked. This appears to be TFD only. For example RFD has a different look and different templates for its relists. I found the TFD manual relist instructions, which are at Wikipedia:Templates for discussion/Closing instructions#Relisting. Can the change you're asking for be made in one of those templates, or do we think it's hard-coded into XFDcloser? Here's some other templates that may be involved in relisting TFDs: https://github.com/wikimedia-gadgets/xfdcloser/blob/077d0b2f4f8d03cc9d20526f9cc7bbde3050fe26/xfdcloser-src/Venue.js#L170-L177. –Novem Linguae (talk) 15:34, 25 August 2024 (UTC)
{{Tfd top}} doesn't format anything, notice that in #Closing the discussion the full close is input as a parameter. I suspect XFDC (and probably Doug's old extension which I still use occasionally) just used that logic as well. I am still thinking about whether I think this is a helpful change vs changing a well-used and long-standing format/convention. Primefac (talk) 16:05, 25 August 2024 (UTC)
We could try using clearer wording. For example, changing the current wording of
The result of the discussion was relisted on 2024 August 6
to
The result of the discussion was relisted (please see the 2024 August 6 TFD discussion page)
Bummer that it's not controlled by a template. That makes this harder to change. Perhaps too hard to be worth it. –Novem Linguae (talk) 16:15, 25 August 2024 (UTC)

It's not only TFD. Here is an FFD example. Zerotalk 00:55, 26 August 2024 (UTC)

Allow non-admins to close CFDs

Hi! I have an easy (I think?) request: Like at WP:TFD, non-admins are permitted to close discussions at WP:CFD as delete (see WP:NACD for the official guideline saying deletion NACs at CFD are okay). Would it be possible to enable this option for non-admins at CFD, like how it is enabled at TFD? Thanks, HouseBlaster (talk  he/they) 23:18, 20 September 2024 (UTC)

@HouseBlaster. Are there any CFD workflows that would change by not having the delete button? For example, for non-admins, maybe instead of trying to delete the page, the gadget would instead need to add the page to a queue / holding cell?
If the admin vs non-admin CFD workflows are the same, this is easy. If the workflows are different, this is hard. –Novem Linguae (talk) 23:12, 23 September 2024 (UTC)
@Novem Linguae: the workflows are identical at this stage in the process: XFDC only closes the discussion, and nothing else – not even deleting the page. Non-admins list their closures at WT:CFDW, but that is facilitated by a separate script (User:Qwerfjkl/scripts/CFDlister). Admins have to list the discussions directly at WP:CFDW, but that is not handled by XFDC. HouseBlaster (talk  he/they) 23:34, 23 September 2024 (UTC)
Oh, besides the fact that NACs should get tagged with {{subst:nacd}}. Otherwise identical. HouseBlaster (talk  he/they) 23:50, 23 September 2024 (UTC)

Nomination for merger of Template:Rfd-NPF

Template:Rfd-NPF has been nominated for merging with Template:Redirect for discussion. Watchers of this page are invited to comment on the discussion at the template's entry on the Templates for discussion page. Thank you. Steel1943 (talk) 22:16, 22 September 2024 (UTC)

I don't see this template in XFDcloser's code. Probably no action needed here. –Novem Linguae (talk) 23:23, 23 September 2024 (UTC)
@Novem Linguae: You are correct, it is probably not; however, this template does appear on redirects tagged by PageTriage, and as hinted above in the top section of this talk page, XFDcloser is not able to remove these tags from redirects after their respective RFD discussions have been closed. Steel1943 (talk) 17:31, 24 September 2024 (UTC)

XFDcloser creating erroneous edit summaries and linking to Undefined after AfD/PROD closures

Long story short, see this diff and the clearly erroneous link to Undefined. This is one diff of many I found with the same issue, but I think only one needs to illustrate the problem. Steel1943 (talk) 16:16, 23 September 2024 (UTC)

@Steel1943. Have you noticed any pattern to this (for example links with spaces, links in a certain namespace, etc.), or does it always happen when XFDcloser removes any wikilink? –Novem Linguae (talk) 23:08, 23 September 2024 (UTC)
@Novem Linguae: Looking through some more recent edit summaries that include the link to undefined, it seems that this link is only caused by delinking pages that have been deleted through the PROD process, not AfD (contrary to what I originally assumed), and happens in title with or without spaces (from what I saw). The only way I was able to figure this out is because Explicit does a good amount of deletions, so I was able to see this pattern. (Explicit, thank you for all that you do; sorry this tool has not been working correctly and makes your PROD article delink edit summaries look wrong.) Steel1943 (talk) 17:36, 24 September 2024 (UTC)
@Primefac: To answer your since-removed comment since you make a good point that I was not aware of myself until you made the comment, it seems that the deletion itself is performed by Twinkle (see Animal Behavior Society), but XFDcloser does the delinking of the page deleted via PROD. Does that mean that Twinkle and XFDcloser interface with each other when both are enabled? (Not sure, and I'm not sure who would know.) Steel1943 (talk) 17:24, 25 September 2024 (UTC)
They are probably independent of each other. An undefined in XFDcloser's edit summary is almost surely a bug in XFDcloser, not Twinkle. –Novem Linguae (talk) 20:50, 25 September 2024 (UTC)
@Novem Linguae: I definitely agree and understand that it is XFDcloser causing the error with the delinking edit summary problems. However, the timestamps for the PROD deletion of Animal Behavior Society (Twinkle) and the delinking of a link to it in another article (the diff in my initial statement [XFDcloser]) are identical. This leads me to believe one of the following: 1) Twinkle has an option built into it to perform delinkings with XFDcloser after a PROD, thus meaning XFDcloser is not sure what to link as a result, or 2) the issue may be caused by user error, possibly by running Twinkle and XFDcloser almost simultaneously. Steel1943 (talk) 21:04, 25 September 2024 (UTC)
I see. I've added https://github.com/wikimedia-gadgets/xfdcloser/issues/93#issuecomment-2375372798 to remind myself or whoever to investigate this more when the ticket is being further researched. –Novem Linguae (talk) 22:24, 25 September 2024 (UTC)
I've cross-posted to WT:TW to see if it's an issue on their end. Primefac (talk) 12:04, 26 September 2024 (UTC)
The bug is not related to Twinkle. PROD deletions are only supported in Twinkle, and although Twinkle has its own Unlink tool, XFDC's unlinking is more feature-rich, so many users tend to prefer that – you can see the option on any non-existing page under "Tools" (vector-2022) or in the "More" dropdown (vector-2010). – SD0001 (talk) 18:12, 26 September 2024 (UTC)
the issue may be caused ... possibly by running Twinkle and XFDcloser almost simultaneously I don't think so, it's also been known to occur when you unlink 3 months after the page was deleted. – SD0001 (talk) 18:16, 26 September 2024 (UTC)
But... you can't even use XFDC if you're not on an XfD page... Primefac (talk) 18:20, 26 September 2024 (UTC)
You can. – SD0001 (talk) 18:33, 26 September 2024 (UTC)
Based on all that has been stated so far, seems both of my assumptions are incorrect and the examples that I provided from Explicit show that they are a fast clicker and that the two gadgets do not technically interrupt each other, meaning this probably has nothing to do with Twinkle. But, it seems there may be a new theory here: Do links to undefined in edit summaries only occur via the "XFDC Unlink" option when the respective page is deleted before running "XFDC Unlink"? Steel1943 (talk) 18:46, 26 September 2024 (UTC)
I tried to test this by adding a wikilink to a non-existent page to my sandbox and to a mainspace redirect. I couldn't get the XFDC Unlink tool to remove them. I don't really want to add a test link to a live article, so might be hard to test this. Might need to install the gadget on testwiki and mess around with it there to do it properly.
Anyway, I've updated the ticket with the latest hypothesis: https://github.com/wikimedia-gadgets/xfdcloser/issues/93
Also, I wonder why we don't have a mainspace sandbox. Would make certain kind of tests much easier. Maybe we could hard-code it into MediaWiki to always noindex it. –Novem Linguae (talk) 20:47, 26 September 2024 (UTC)

Rfd-NPP not recognized

May be unrelated, but much of the time closing as Keep at RfD does not do anything to the redirect page. I have to manually remove the deletion notice and tags. I'm on Vector Legacy (2010). Jay 💬 07:05, 3 November 2024 (UTC)

@Jay: It's probably unrelated: XFDcloser doesn't recognize {{Rfd-NPF}} (specifically {{Rfd-NPF/core}}), the RFD tag placed by PageTriage. It's been a huge headache for a while. Steel1943 (talk) 18:29, 5 November 2024 (UTC)

Relisted on wrong day on WP:RFD

See these edits: ; these edits occurred on 5 November 2024, but XFDcloser relisted the discussion on the 4 November 2024 (1 day earlier) page. Steel1943 (talk) 18:26, 5 November 2024 (UTC)

Steel1943, known bug: https://github.com/wikimedia-gadgets/xfdcloser/issues/91 Qwerfjkltalk 19:16, 5 November 2024 (UTC)
Indeed, I seem to recall it has to do with the user time rather than UTC. Primefac (talk) 20:12, 5 November 2024 (UTC)
Yep, annoying stuff like that is why I leave my time preference on Wikipedia as UTC. Prevents a whole lotta garbagio, and is probably the easiest workaround. Steel1943 (talk) 20:39, 5 November 2024 (UTC)
@Significa liberdade: FYI. Steel1943 (talk) 21:21, 5 November 2024 (UTC)
Would this still be the case if I made the edits on November 5 at 10:20 AM my time? I can understand this occurring if it were November 4 my time but November 5 UTC, but it seems odd if both are on the same day. Significa liberdade (she/her) (talk) 21:24, 5 November 2024 (UTC)
Can't say for certain. This gadget has been wonky for a while, and it hasn't been maintained for a few years. Only thing most have been doing is reporting bugs and figuring out the workarounds and using those so the tool will work for them. For me, I have left my global time zone set as UTC, even though it's not my actual time zone, and I have yet to have any odd issue happen with tools or gadgets based on timestamps. Steel1943 (talk) 22:34, 5 November 2024 (UTC)
Figure I'd add to this: Since this tool is widely used, though not recently maintained at all, in 2022, an editor made some REALLY great updates to {{Rfd2}}, but ... they had to be reverted due to how this tool works and since there was no one available to update this tool to work for {{Rfd2}}'s new functionality at the time. 😫 Steel1943 (talk) 22:40, 5 November 2024 (UTC)

XFDcloser adds |2=[Article Name] to RFD templates

What do these changes do? 1, 2. They don't update the RfD link or anything. Hyphenation Expert (talk) 06:16, 3 November 2024 (UTC)

It ensures the link in the RFD/core template will go to the correct section of the initial nomination date subpage, especially with nominations with multiple redirects. Steel1943 (talk) 18:31, 5 November 2024 (UTC)
Maybe it used to do that, but no longer? Using Scottish Nosepickers as an example... Both before and after the relist change (2=Scottish Nose-pickers), the RfD link still just uses the page title as anchor (#Scottish_Nosepickers). And the anchor already works regardless because every nom in a multi-nom has its own "span-id" element. Hyphenation Expert (talk) 23:49, 5 November 2024 (UTC)

Add draftify result?

Can I firstly say, thank you so much Novem Linguae for all your work with patching and bug investigating over the past couple of months - you are an unsung hero!

This is a very greedy wishlist request but I was wondering if there was capacity at some point in the future to add "draftify" as one of the results for AfD? It seems to be a reasonably common outcome nowadays and, while it is eminently achievable by using "custom" and then actioning all the page moves etc., would be amazing for it to be all bundled up. Fully understand if not possible though, or not a priority given everything else happening.

Cheers, Daniel (talk) 13:05, 28 August 2024 (UTC)

Looks like Vanamonde93 already requested this back in 2022. Ticket. I'll slap a high priority tag on it since it is now requested by multiple people. (This just means that if a volunteer dev ever sits down to work on tickets, hopefully they consider prioritizing it. There's no active development at the moment.) By the way, can you go into a bit more detail about the "extra steps" for drafts? Is the only extra step moving the page to the draft namespace, or are there other steps? Thanks. –Novem Linguae (talk) 13:19, 28 August 2024 (UTC)
It's late here but to my memory, click 'custom' > type "draftify" > close > go to article > move article (and tick 'move talk page' and 'do not leave redirect') > comment out categories on draft page (could be automated?). The bot adds the 'draft from mainspace' template afterwards. Might be something else? Daniel (talk) 13:25, 28 August 2024 (UTC)
I feel like a slight tweak of this would actually make it more useful across more circumstances. For example, at TFD there are (not super-often) "userfications" made to templates, where the template is moved to a userspace, similar to a draftification at AFD. It might be worth having a generic "move" option in the closer options, where the closer can choose the new name of the page (e.g. "Example -> Draft:Example" or "Template:Example -> User:Joe/Template:Example") which could do the move-without-redirect. I do recognise that moving pages is a bit more involved than just editing or deleting pages, so if that sort of expanded functionality is too much, then I guess I'll just have to live with it! Primefac (talk) 13:34, 28 August 2024 (UTC)
Seems like there could be 3 additional modes to add here: AFD draftify, AFD userfy, and TFD userfy. Any others? I'm not sure a move feature would be as useful for things like CFD, RFD, and FFD. Draftify has enough unique stuff going on (turning off categories, adding Moved Draft template) in it that it may make sense to keep it separate. There's also some positives to pre-programming the correct terminology in. For example "draftify" would probably be better to write in an AFD close than "move to Draft:X". –Novem Linguae (talk) 13:57, 28 August 2024 (UTC)
Just noting that I came here ot ask the same question. This is an amazingly helpful tool, this functionality would just make it that much better. Just Step Sideways from this world ..... today 01:56, 24 November 2024 (UTC)

Close log

I think it would be very nice to have the tool automatically keep a close log, like twinkle does for CSD and AfD noms.

Kingsmasher678 (talk) 19:42, 4 December 2024 (UTC)

Delinking/delisting Bug?

Is this an existing or known bug, shouldn't the script be delinking instead of removing entirely? Paper9oll (🔔📝) 12:12, 21 December 2024 (UTC)

The edit summary says "removing links / list items". The "removing list items" part makes it seem like it might be intentionally programmed this way. Interesting. If so, I think just always de-linking might be a bit safer. –Novem Linguae (talk) 13:21, 21 December 2024 (UTC)
Ya, I think it would be safer to change it do delinking as this wasn't caught until a day later by a new editor. Paper9oll (🔔📝) 13:26, 21 December 2024 (UTC)
Header changed to a more descriptive one
Per Wikipedia:XFDcloser#Unlinking_backlinks this is an issue with the closer not pressing the right buttons. In other words, it is not a bug. Primefac (talk) 13:35, 23 December 2024 (UTC)
Thanks for that link. I didn't realize that each list removal prompted the user to manually approve it. It should be safe to keep this feature. Closing without actionNovem Linguae (talk) 17:25, 23 December 2024 (UTC)
Noted, thanks! Paper9oll (🔔📝) 18:52, 23 December 2024 (UTC)

Toomanyvalues

Can someone please take a look at Wikipedia:Miscellany for deletion/User:HeyDuggeeOfficial2024/sandbox/The Olden Days and tell me if anything can be done to make XFDcloser work? —Alalch E. 21:23, 6 January 2025 (UTC)

What's the steps to reproduce? Do you just hit close (not quickClose), try to close all as delete, then it gives a "Toomanyvalues" error message in the user interface without doing anything? –Novem Linguae (talk) 22:35, 6 January 2025 (UTC)
Dou you see the buttons? I didn't click close and. What I see is that the XFDcloser buttons are missing. They show for a fraction of a second and are then replaced by the message "toomanyvalues error retrieving page information (reload the page to try again)". Which is due to too many pages being listed, supposedly. I tried to look what the max number of links is but couldn't find this information. —Alalch E. 22:56, 6 January 2025 (UTC)
Works for me. Is probably an mw:Action API rate limit error due to not being an admin. This is probably ticket #60. –Novem Linguae (talk) 23:10, 6 January 2025 (UTC)
As a workaround, maybe have an admin close it on your behalf. If you want, you can give me a close result and rationale, and I'll try to do the close for you, and then we can edit in your signature to the close message. What would you like the result and close rationale to be? –Novem Linguae (talk) 23:20, 6 January 2025 (UTC)
Oh great, thanks. Everything is fine then. I have no intent of closing. I just started this MfD this way and then became worried about including too many pages basically, "breaking" XFCloser, and causing a potential hassle for an admin who would close. So I posted here to see what's up. —Alalch E. 23:29, 6 January 2025 (UTC)
I think the admin limit is 500, so should be good :) –Novem Linguae (talk) 23:35, 6 January 2025 (UTC)

How to automatically remove deleted templates?

I noticed XFDcloser does not automatically remove deleted templates from articles when closing a TfD. Is there an option to do this, or does XFDcloser not yet support this feature? Ixfd64 (talk) 18:53, 2 February 2025 (UTC)

It's a decent idea, but removing transclusions of a template is not the same as simply unlinking backlinks. WP:TFDH always has entries for templates that need removal, even the simple ones. While yes, there are occasions where straight-forward removal is acceptable (e.g. a navbox being deleted) I do not want to have to clean up after someone who accidentally deletes a template called on thousands of pages that needs either substing, a merge, or replacement. Keep listing things at the holding cell and let people who have the time to do the cleanup take care of it. Primefac (talk) 07:20, 4 February 2025 (UTC)
Fair enough. I guess I'll stick to the holding cell for the less simple cases. Ixfd64 (talk) 18:52, 4 February 2025 (UTC)
Closing without actionNovem Linguae (talk) 22:23, 4 February 2025 (UTC)

TM:Xfd relist swap back to div element

There's an unfortunate selector in the vector-2022 CSS that makes some replies to the TM:Xfd relist overlap text. The selector can be avoided by using <div> rather than <p>. Would making this swap break things? See the section at Template talk:XfD relist#Overlapping Replies for more info. Synpath 03:50, 10 February 2025 (UTC)

Strange article linkage

Let me start by saying this is probably my favorite gadget for Wikipedia. It has always worked perfectly for me until my recent closure of Wikipedia:Articles for deletion/Vingtaine du Rondin. The gadget properly identified links to that article, but also mysteriously identified pages linking Roads in Jersey. I couldn't figure out why those links would be affected by the closing, so I thought I would mention it here. Let me know if I am missing something obvious. Mojo Hand (talk) 16:19, 25 April 2025 (UTC)

Possibly because the redirect Roads in Jersey had two navboxes, one of which linked to Vingtaine du Rondin. I have since removed the navboxes as they shouldn't appear on redirect pages. I suspect that if you delete an article linked to from a redirect page, then the tool assumes that it redirects to the article being deleted, even if it's not. It's still an error though. CX Zoom[he/him] (let's talk • {CX}) 17:57, 25 April 2025 (UTC)

Tests failing + general question about best venue for technical questions

@Novem Linguae What's the best place to bug you with questions I have about XfD closer? I'm taking a stab at implementing a few of the outstanding issues and it looks like there's a pair of tests failing before I've made any changes, and the talk page seems like a poor fit but so does github. (My main question is whether the GetRelistInfo tests failing is a known issue or represents a likely problem with my setup, but I expect I may have more unless you tell me you're not up for fielding questions about this given then immense number of technical things you're listed as the maintainer for, which would be totally reasonable.) Rusalkii (talk) 21:57, 28 April 2025 (UTC)

Yeah, this talk page is fine.
CI seems to be passing on GitHub: https://github.com/wikimedia-gadgets/xfdcloser/pulls and https://github.com/wikimedia-gadgets/xfdcloser/commits/master/ (note the green check marks). Are you just doing npm test in localhost? How would I reproduce this if I wanted to help you troubleshoot? –Novem Linguae (talk) 22:10, 28 April 2025 (UTC)
I cloned it, ran npm run build without making any changes, hit an error (xfdcloser/dist/loader-dev.js no such file or directory), ran npm run test, and got all tests passing except
1) GetRelistInfo
       gets relist wikitexts for TfD:
     TypeError: Cannot add property user, object is not extensible
      at Context.<anonymous> (test/testTaskGetRelistInfo.js:117:3)
      at processImmediate (node:internal/timers:483:21)
2) GetRelistInfo
       gets relist wikitexts for TfD, multiple pages:
     TypeError: Cannot add property user, object is not extensible
      at Context.<anonymous> (test/testTaskGetRelistInfo.js:133:3)
      at processImmediate (node:internal/timers:483:21)
Rusalkii (talk) 22:23, 28 April 2025 (UTC)
Sorry for the truly cursed formatting, I'm not sure how to do codeblocks properly onwiki. Rusalkii (talk) 22:24, 28 April 2025 (UTC)
<syntaxhighlight> or <pre> are good for multi-line blocks :) Will try to reproduce this if I get time and let you know what happens. –Novem Linguae (talk) 23:30, 28 April 2025 (UTC)

Using arrow keys when doing a multi-result close should not change the results

This is extremely frustrating behavior that makes it far more difficult than necessary to write/edit a long rationale. Elli (talk | contribs) 19:41, 3 May 2025 (UTC)

See #Unable to type in Multiple results. This has been there from September 2022, and whatever changes were made that created the bug were never reverted. Are you using Firefox? Jay 💬 20:19, 3 May 2025 (UTC)
Yes. Elli (talk | contribs) 02:54, 11 May 2025 (UTC)
That regression was so bad, typing anything on the second screen of the wizard too changes the results on the first screen. I wanted to add an rcat for one of the entries being closed as a redirect, I selected "C" for the capitalization rcat, and it changed all my selections in the first page to "Custom". Logged out, logged in to Chrome, repeated the steps, and it went through fine. Jay 💬 05:39, 11 May 2025 (UTC)

Empty noinclude

It looks like XFDcloser leaves back an empty <noinclude></noinclude> when removing the templates from the page in question. I'm pretty sure this serves no purpose and should be fixed. Laura240406 (talk) 13:59, 29 June 2025 (UTC)

Examples please? Primefac (talk) 14:06, 29 June 2025 (UTC)
e.g. here or here Laura240406 (talk) 14:09, 29 June 2025 (UTC)

Bug - Removing list entry removes entire line even if there is other markup

I'm not sure why, but XFDcloser seemed to break this page with this edit. (cc: @Liz:) I fixed it but wanted to let you know. - JFHutson (talk) 01:29, 3 July 2025 (UTC)

Diff: https://en.wikipedia.org/w/index.php?title=Presbyterian_Church_in_America&diff=prev&oldid=1298519298Novem Linguae (talk) 02:03, 3 July 2025 (UTC)
Just noting I've changed the header to be more descriptive. Primefac (talk) 20:21, 4 July 2025 (UTC)

Bug with CFD closes

Steps to reproduce:

  1. Install XFDC
  2. Find a CFD which uses {{category links}} to list the categories being discussed. For example, Wikipedia:Categories for discussion/Log/2025 June 22#Category:Mozambican Muslims (which is already closed)
  3. Close the CFD as "keep", "no consensus", or "custom"
  4. Choose "remove nomination templates, tag talk pages" in the "actions" dropdown

What happens: Talk:Edit will be tagged as if it was under discussion, in addition to the categories being discussed. You can see Special:PageHistory/Talk:Edit for some examples.

What should happen: Just the categories should be tagged.

This started happening after {{category links}} was updated after a a TFD to use {{pagelinks}} rather than {{Lx}}. I would be shocked if the bug was unrelated. Whatever code parsers {{Lc}} is where I'd start looking. Best, HouseBlaster (talk • he/they) 19:10, 5 July 2025 (UTC)

HouseBlaster. Fixed. Thanks for the bug report. –Novem Linguae (talk) 00:19, 10 April 2026 (UTC)

Unable to type in Multiple results

I started seeing the problem on Sep 9 or 10 (see WT:Redirects for discussion#XFDcloser is broken), but it may have been there from earlier. Typing into the Result Summary or Rationale fields of the XFDcloser is not possible. It treats characters as keyboard shortcuts and does other stuff. Apparently it happens for Multiple results only. Jay 💬 06:54, 25 September 2022 (UTC)

Also typing in something in the RCAT page of the wizard messes up the earlier result selections. I typed R and all my results went back to Retarget 😖. Jay 💬 06:56, 30 September 2022 (UTC)
@Evad37: Can a bug be filed for this, or maybe revert the September 9-10 change that caused this regression? Jay 💬 11:09, 20 November 2022 (UTC)
I don't see any code changes to XFDcloser around this time in GitHub nor to MediaWiki:Gadget-XFDcloser.js, MediaWiki:Gadget-XFDcloser-core.js, or MediaWiki:Gadget-XFDcloser.css. It's possible that something changed in mediawiki or firefox and trickled down to XFDcloser. –Novem Linguae (talk) 00:25, 6 July 2025 (UTC)
This happens on Firefox which I use. This doesn't happen with Chrome. But today, I see that the Multiple results option is fully broken. The "Next" button is not getting enabled. Jay 💬 08:36, 4 February 2023 (UTC)
So any time I have to close a RfD with multiple results, I log out of Firefox, log in to Chrome, and do the close.Whatever change was made to this tool in Sep 2022 should be reverted. Jay 💬 13:48, 26 March 2023 (UTC)
I had this same problem – I had to copy/paste my rationale, etc. from a separate page. When I typed "S", everything went to "Soft redirect". Can someone please fix this? It was quite annoying Edward-Woodrow :) [talk] 19:58, 14 August 2023 (UTC)
Ran into this bug again today on Firefox after seemingly not having seen it for a while. signed, Rosguill talk 17:25, 8 October 2023 (UTC)
Today I closed an RfD where one of the entries was Delete and the other was Retarget, but the delete entry was not actually deleted but retargeted to "null". Jay 💬 14:28, 27 December 2024 (UTC)
@Jay. Do you think this is still a Firefox-only bug? Were you using Firefox for this particular close? –Novem Linguae (talk) 20:33, 27 December 2024 (UTC)
Yes, I was using Firefox. I'll use Chrome the next time I have a chance, and update here. Jay 💬 05:48, 28 December 2024 (UTC)

CfM not removed from second category

Although {{cfm full}} was removed from Category:Motile cells, it should have also been removed from Category:Cell movement but wasn't. 174.138.212.166 (talk) 20:06, 11 July 2025 (UTC)

Redirect notice

Please note that I am nominating this redirect to be a dab page: Template:Relist. Please see the redirect discussion there if any input is needed. Interstellarity (talk) 20:40, 22 July 2025 (UTC)

Circular redirects in hatnotes

Hi all, is there any possible way to get XFDcloser to catch circular redirects in hatnotes like this in response to WP:Articles for deletion/List of Worldwar characters? As seen, the removal has to be done manually since the tool ignores/bypasses them. Left guide (talk) 03:23, 25 July 2025 (UTC)

XFDcloser detecting the wrong signature(?)

See Wikipedia:Redirects for discussion/Log/2025 July 25#Affect of ice age in uk which XFDcloser thinks is ready to close even though it's been open for less than 24 hours. I'm guessing this happened because nom's comment includes a quote that has a signature so XFDcloser thinks the RFD was opened in 2005. Warudo (talk) 10:01, 26 July 2025 (UTC)

Problem with XFDCloser

Hello, whomever monitors this talk page,

I ran into a problem with XFDcloser. I use it on a daily basis to close AFD discussions, but when I closed Wikipedia:Articles for deletion/List of Church of England instruments, XFDcloser unlinked or removed a lot of mentions of words, terms and subjects that weren't the article subject (List of Church of England instruments). It has caused a mess that other editors helped clean up. Do you know why XFDcloser would remove links to terms that weren't the AFD subject when closing an AFD? I haven't had this problwm before now. Thanks for any explanation you can provide. Liz Read! Talk! 18:37, 25 August 2025 (UTC)

There have been no deploys this month, so recent code changes are not to blame. Must be an unusual edge case. Can you link some of the diffs where XFDcloser unlinked incorrect terms associated with List of Church of England instruments? –Novem Linguae (talk) 19:08, 25 August 2025 (UTC)
Some example diffs: . The problem could be related to the redirect pages having {{UK legislation}} on them e.g. https://en.wikipedia.org/w/index.php?title=Finance_Act_1949&redirect=no. Until the de-linking, that template did include a link to List of Church of England instruments.
As far as I know we don't normally include templates other then categorisation ones on redirect pages. @Hughbe98, is there a reason you added {{UK legislation}} to these pages? the wub "?!" 21:36, 25 August 2025 (UTC)
Hi - I added the navbox to pages for Acts of Parliament of the UK. It’s standard practice for articles about acts of parliament. There are equivalents for Parliaments of GB and England. Hughbe98 (talk) 22:00, 25 August 2025 (UTC)
Please don't (and please remove them). It's one thing to categorise a redirect, but they should not have article content on them such as navboxes. Primefac (talk) 00:18, 26 August 2025 (UTC)
I think the problem is that UnlinkBacklinks.js considers any redirect found in the backlinks as something to unlink, rather than only redirects to the page being deleted. jlwoodwa (talk) 00:02, 26 August 2025 (UTC)

http error at CfD

Hello, when closing at CfD, instead of the standard close/quick close/relist sometimes I get a "http error retrieving page information (reload the page to try again)". This seems to happen in groups e.g. everything at WP:Categories for discussion/Log/2025 September 3 is normal but every discussion at WP:Categories for discussion/Log/2025 September 4 gives an error (though I'm occasionally able to get past this by clicking the buttons before the error message loads, and then it works fine). There's also the "toomanyvalues error retrieving page information (reload the page to try again)", but that might just be there to prevent NACs from making bigger closes? Not sure if this is a CfD problem or XfDcloser problem but help/advice appreciated :). Cheers! GoldRomean (talk) 04:20, 10 September 2025 (UTC)

HTTP errors are usually internet connection problems. How's your internet connection? Any slowness or pages occasionally not loading or occasional outages?
I have no idea on the toomanyvalues.
Would love to hear if others also get http errors or toomanyvalues errors when closing CSDs, especially non admins, to see if there's any patterns here. –Novem Linguae (talk) 05:49, 10 September 2025 (UTC)
Now that I think of it, Wikipedia does load (slightly) longer than expected on occassion. Interestingly enough, tried a different WiFi and on the 4 Sept log #Category:Television shows about mother–daughter relationships and above now works, below still gives errors. (If it helps toomanyvalues is showing up for American sportspeople by country of descent and Category:Balestrand on the 3 Sept log.)
Pinging some other CfD NACs @Qwerfjkl, @Hilst, probably others I missed. Cheers. GoldRomean (talk) 14:56, 10 September 2025 (UTC)
Novem Linguae, this is the same toomanyvalues error from https://github.com/wikimedia-gadgets/xfdcloser/pull/87. The http error is caused by a similar issue, I mentioned it in my pull request as well. It's not a network error, it's because the request uri is too long. Qwerfjkltalk 15:19, 10 September 2025 (UTC)
Ah. Copy. I've been meaning to review your patch, but it is a risky patch, and hard to test. Will see if I can find some time to dive into it more. –Novem Linguae (talk) 20:02, 10 September 2025 (UTC)
Fixed, hopefully. Patch merged and deployed. Will take effect in 10 minutes. –Novem Linguae (talk) 21:36, 10 September 2025 (UTC)
Thank you both! It looks like it's working now (and the toomanyvalues ones now give [XFDcloser: Too many pages for non-admin]). Cheers, GoldRomean (talk) 00:11, 11 September 2025 (UTC)
Looks like that's a hard-coded restriction. if ( !this.userIsSysop && this.pages.length > 50 ) { this.status = "[XFDcloser: Too many pages for non-admin]"; } Funny that we did all this work on the API to allow chunking, but now we're running into a hard coded restriction.
Should the hard-coded restriction be removed? Or is it prudent to only allow admins to close big XFDs? If we think it's OK to remove, maybe Qwerfjkl would be willing to write another patch. –Novem Linguae (talk) 03:51, 11 September 2025 (UTC)
Novem Linguae, I think there's no need for the restriction. WP:BADNAC obviously applies, but I think it falls on the closer to assess whether they should actually perform a close. There can be routine nominations that have more than 50 pages. I might have a go at writing a patch later. Qwerfjkltalk 09:28, 11 September 2025 (UTC)
Novem Linguae, https://github.com/wikimedia-gadgets/xfdcloser/pull/112 should address this. The test passes. Qwerfjkltalk 20:41, 18 September 2025 (UTC)

Proposal to allow non-admins to close huge XFDs (>50 pages)

There's a patch in the queue to allow non-admins to close huge XFDs (>50 pages). This is currently restricted, but after this patch would no longer be restricted. Is everyone OK with this? Will merge the patch in a couple days if there's no objections.

The risk is an inexperienced gadget user closing a big XFD incorrectly and making a mess. Could require a lot of reverting. If the community is OK with that risk, happy to merge the patch. –Novem Linguae (talk) 20:52, 18 September 2025 (UTC)

Novem Linguae, which XfDs actually allow making edits to a lot of pages (for non-admins)? I know at CfD it's done by a bot (and so the change to XFDCloser won't cause increased potential for a mess), but presumably at other XfDs it's done differently? Qwerfjkltalk 20:56, 18 September 2025 (UTC)
I'm not sure. Maybe one of the tests you or I should do is go on testwiki, log into a non-admin account, XFDclose an MFD with 2 pages as delete, and see what XFDcloser does. Maybe it's smart enough to take away the delete button? –Novem Linguae (talk) 21:07, 18 September 2025 (UTC)

AfD tags not being removed

When this AfD was closed early, the deletion tags weren't removed from the article. The article history on the talk page was also not updated. – SD0001 (talk) 10:58, 4 October 2025 (UTC)

If this is the first time that's happened, it might be a client-side issue. Primefac (talk) 12:58, 4 October 2025 (UTC)

"XFDcloser" listed at Redirects for discussion

The redirect XFDcloser has been listed at redirects for discussion to determine whether its use and function meets the redirect guidelines. Readers of this page are welcome to comment on this redirect at Wikipedia:Redirects for discussion/Log/2025 October 17 § JWBS until a consensus is reached. Rusalkii (talk) 20:14, 17 October 2025 (UTC)

Discussion at Template talk:Afd top

 You are invited to join the discussion at Template talk:Afd top. Matrix ping mewhen u reply (t? - c) 20:51, 17 October 2025 (UTC)