Wikipedia:Bots/Requests for approval/TenshiBot 2
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard. The result of the discussion was
Approved.
Operator: Tenshi Hinanawi (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)
Time filed: 21:35, Monday, May 19, 2025 (UTC)
Automatic, Supervised, or Manual: automatic
Programming language(s): Python
Source code available:
Function overview: Notifies AfC reviewers of drafts that are still marked as being reviewed after 48 hours, and returns the draft to the AfC queue after 72 hours if no action is taken.
Links to relevant discussions (where appropriate): Wikipedia_talk:WikiProject_Articles_for_creation#Drafts_Marked_as_Being_Reviewed_but_Forgotten, Wikipedia:Bot_requests#A_auto-message_bot_for_AfC_reviews?
Edit period(s): Daily
Estimated number of pages affected: <5
Exclusion compliant (Yes/No): Yes
Already has a bot flag (Yes/No): Yes
Function details: Bot goes through Category:Pending AfC submissions being reviewed now and checks if 48 hours have passed, and notifies the reviewer if so. Where the reviewer has been notified and 72 hours have passed, the bot will mark the draft as pending again.
Discussion
edit
Approved for trial (30 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. – DreamRimmer ■ 16:27, 20 May 2025 (UTC)[reply]
Trial complete. Relevant contribs. There's an issue with inserting data into the toolsdb its using, which I tried to fix during the trial (unsuccessfully), meaning I had to input data manually. Not exactly sure on what is causing the issue however. Tenshi! (Talk page) 21:52, 19 June 2025 (UTC)[reply]
- @Tenshi Hinanawi: You should call
connection.commit()afterINSERTorUPDATEstatements to make sure the changes are saved, as Connector/Python does not autocommit by default. Callingcursor.fetchone()after these operations is unnecessary, since they do not return any rows, so those calls should be removed. Currently, a new database connection is opened for each check or notification, but the best approach would to reuse a connection whenever possible. – DreamRimmer ■ 11:29, 20 June 2025 (UTC)[reply]- Didn't know that it didn't autocommit for mysql.connector. Fixed that and the multiple DB connections issue. — Tenshi! (Talk page) 01:27, 22 June 2025 (UTC)[reply]
- I see the code has been modified significantly, so I am giving this another trial to make sure everything works as intended. – DreamRimmer ■ 13:37, 22 June 2025 (UTC)[reply]
Approved for extended trial (10 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. – DreamRimmer ■ 13:40, 22 June 2025 (UTC)[reply]
Trial complete. Relevant contribs. Nothing wrong with the database this time. Tenshi! (Talk page) 13:18, 2 July 2025 (UTC)[reply]
Approved. – DreamRimmer ■ 15:46, 2 July 2025 (UTC)[reply]
- I see the code has been modified significantly, so I am giving this another trial to make sure everything works as intended. – DreamRimmer ■ 13:37, 22 June 2025 (UTC)[reply]
- Didn't know that it didn't autocommit for mysql.connector. Fixed that and the multiple DB connections issue. — Tenshi! (Talk page) 01:27, 22 June 2025 (UTC)[reply]
- @Tenshi Hinanawi: You should call
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard.